Merge pull request 'Also handle transactions without category' (#51) from transactions_without_category into master

Reviewed-on: #51

postgres/cumultative-balances.sql.go

@@ -19,7 +19,7 @@ SELECT COALESCE(ass.date, tra.date), COALESCE(ass.category_id, tra.category_id),
        COALESCE(tra.amount, 0)::decimal(12,2) as transactions
 FROM assignments_by_month as ass
 FULL OUTER JOIN transactions_by_month as tra ON ass.date = tra.date AND ass.category_id = tra.category_id
-WHERE (ass.budget_id IS NULL OR ass.budget_id = $1) AND (tra.budget_id IS NULL OR tra.budget_id = $1)
+WHERE COALESCE(ass.budget_id, tra.budget_id) = $1
 ORDER BY COALESCE(ass.date, tra.date), COALESCE(ass.amount, tra.amount)
 `
 

postgres/queries/cumultative-balances.sql

@@ -4,5 +4,5 @@ SELECT COALESCE(ass.date, tra.date), COALESCE(ass.category_id, tra.category_id),
        COALESCE(tra.amount, 0)::decimal(12,2) as transactions
 FROM assignments_by_month as ass
 FULL OUTER JOIN transactions_by_month as tra ON ass.date = tra.date AND ass.category_id = tra.category_id
-WHERE (ass.budget_id IS NULL OR ass.budget_id = @budget_id) AND (tra.budget_id IS NULL OR tra.budget_id = @budget_id)
+WHERE COALESCE(ass.budget_id, tra.budget_id) = @budget_id
 ORDER BY COALESCE(ass.date, tra.date), COALESCE(ass.amount, tra.amount);

postgres/queries/transactions.sql

@@ -34,8 +34,7 @@ WHERE t.budget_id = $1;
 -- name: GetTransactionsForAccount :many
 SELECT  t.*
 FROM display_transactions AS t
-WHERE t.account_id = $1
+WHERE t.account_id = $1;
-LIMIT 200;
 
 -- name: DeleteAllTransactions :execrows
 DELETE FROM transactions

postgres/schema/0019_ignore-off-budget-in-transactions-by-month.sql

@@ -0,0 +1,13 @@
+-- +goose Up
+CREATE OR REPLACE VIEW transactions_by_month AS 
+        SELECT date_trunc('month', transactions.date)::date as date, transactions.category_id, accounts.budget_id, SUM(amount) as amount
+        FROM transactions
+        INNER JOIN accounts ON accounts.id = transactions.account_id AND accounts.on_budget
+        GROUP BY date_trunc('month', transactions.date), transactions.category_id, accounts.budget_id;
+
+-- +goose Down
+CREATE OR REPLACE VIEW transactions_by_month AS 
+        SELECT date_trunc('month', transactions.date)::date as date, transactions.category_id, accounts.budget_id, SUM(amount) as amount
+        FROM transactions
+        INNER JOIN accounts ON accounts.id = transactions.account_id
+        GROUP BY date_trunc('month', transactions.date), transactions.category_id, accounts.budget_id;

postgres/transactions.sql.go

@@ -183,7 +183,6 @@ const getTransactionsForAccount = `-- name: GetTransactionsForAccount :many
 SELECT  t.id, t.date, t.memo, t.amount, t.group_id, t.status, t.account, t.payee_id, t.category_id, t.payee, t.category_group, t.category, t.transfer_account, t.budget_id, t.account_id
 FROM display_transactions AS t
 WHERE t.account_id = $1
-LIMIT 200
 `
 
 func (q *Queries) GetTransactionsForAccount(ctx context.Context, accountID uuid.UUID) ([]DisplayTransaction, error) {

server/budgeting.go

@@ -139,6 +139,11 @@ func (h *Handler) calculateBalances(budget postgres.Budget, month Month,
 	categoriesWithBalance := []CategoryWithBalance{}
 
 	moneyUsed := numeric.Zero()
+	categories = append(categories, postgres.GetCategoriesRow{
+		Group: "Income",
+		Name:  "No Category",
+		ID:    uuid.UUID{},
+	})
 	for i := range categories {
 		cat := &categories[i]
 		if cat.ID == budget.IncomeCategoryID {