Minimal linting improvements

server/account_test.go

@@ -14,7 +14,7 @@ import (
 	"github.com/gin-gonic/gin"
 )
 
-func init() {
+func init() { //nolint:gochecknoinits
 	txdb.Register("pgtx", "pgx", "postgres://budgeteer_test:budgeteer_test@localhost:5432/budgeteer_test")
 }
 

server/autocomplete.go

@@ -1,7 +1,6 @@
 package server
 
 import (
-	"fmt"
 	"net/http"
 
 	"git.javil.eu/jacob1123/budgeteer/postgres"
@@ -13,7 +12,7 @@ func (h *Handler) autocompleteCategories(c *gin.Context) {
 	budgetID := c.Param("budgetid")
 	budgetUUID, err := uuid.Parse(budgetID)
 	if err != nil {
-		c.AbortWithError(http.StatusBadRequest, fmt.Errorf("budgetid missing from URL"))
+		c.AbortWithStatusJSON(http.StatusBadRequest, ErrorResponse{"budgetid missing from URL"})
 		return
 	}
 
@@ -35,7 +34,7 @@ func (h *Handler) autocompletePayee(c *gin.Context) {
 	budgetID := c.Param("budgetid")
 	budgetUUID, err := uuid.Parse(budgetID)
 	if err != nil {
-		c.AbortWithError(http.StatusBadRequest, fmt.Errorf("budgetid missing from URL"))
+		c.AbortWithStatusJSON(http.StatusBadRequest, ErrorResponse{"budgetid missing from URL"})
 		return
 	}
 

server/budget.go

@@ -1,7 +1,6 @@
 package server
 
 import (
-	"fmt"
 	"net/http"
 
 	"git.javil.eu/jacob1123/budgeteer"
@@ -20,7 +19,7 @@ func (h *Handler) newBudget(c *gin.Context) {
 	}
 
 	if newBudget.Name == "" {
-		c.AbortWithError(http.StatusNotAcceptable, fmt.Errorf("Budget name is needed"))
+		c.AbortWithStatusJSON(http.StatusBadRequest, ErrorResponse{"budget name is required"})
 		return
 	}
 

server/budgeting.go

@@ -85,7 +85,8 @@ func (h *Handler) budgetingForMonth(c *gin.Context) {
 	}
 
 	// skip everything in the future
-	categoriesWithBalance, moneyUsed, err := h.calculateBalances(c, budget, firstOfNextMonth, firstOfMonth, categories, cumultativeBalances)
+	categoriesWithBalance, moneyUsed, err := h.calculateBalances(
+		c, budget, firstOfNextMonth, firstOfMonth, categories, cumultativeBalances)
 	if err != nil {
 		return
 	}

server/http.go

@@ -104,7 +104,11 @@ func (h *Handler) ServeStaticFile(c *gin.Context, fullPath string) {
 		return
 	}
 
-	http.ServeContent(c.Writer, c.Request, stat.Name(), stat.ModTime(), file.(io.ReadSeeker))
+	if file, ok := file.(io.ReadSeeker); ok {
+		http.ServeContent(c.Writer, c.Request, stat.Name(), stat.ModTime(), file)
+	} else {
+		panic("File does not implement ReadSeeker")
+	}
 }
 
 func enableCachingForStaticFiles() gin.HandlerFunc {

server/transaction.go

@@ -50,7 +50,7 @@ func (h *Handler) newTransaction(c *gin.Context) {
 	}*/
 
 	// if !transactionUUID.Valid {
-	new := postgres.CreateTransactionParams{
+	newTransaction := postgres.CreateTransactionParams{
 		Memo:       payload.Memo,
 		Date:       time.Time(payload.Date),
 		Amount:     amount,
@@ -59,7 +59,7 @@ func (h *Handler) newTransaction(c *gin.Context) {
 		CategoryID: payload.Category.ID, // TODO handle new category
 		Status:     postgres.TransactionStatus(payload.State),
 	}
-	_, err = h.Service.CreateTransaction(c.Request.Context(), new)
+	_, err = h.Service.CreateTransaction(c.Request.Context(), newTransaction)
 	if err != nil {
 		c.AbortWithError(http.StatusInternalServerError, fmt.Errorf("create transaction: %w", err))
 	}