jacob1123/forge-master
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Clean up sacrifice candidate reasons

Browse Source
This commit is contained in:
Jan Bader
2026-06-16 20:37:12 +02:00
parent b8b1346f3f
commit 83ceb772fe
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
app.js
+4 -2
View File
@@ -358,7 +358,6 @@ function scorePiece(piece, profile, totals) {
for (const effect of piece.effects) { for (const effect of piece.effects) {
if (!effect.type) { if (!effect.type) {
reasons.push("missing effect slot");
continue; continue;
} }
const def = effectById(effect.type); const def = effectById(effect.type);
@@ -445,7 +444,10 @@ function renderUpgrades(profile, totals, currentDps) {
} }
function renderSacrifices(pieceScores) { function renderSacrifices(pieceScores) {
const weakest = [...pieceScores].sort((a, b) => a.score - b.score).slice(0, state.recommendationCount); const weakest = pieceScores
.filter(({ piece }) => !piece.noEffects)
.sort((a, b) => a.score - b.score)
.slice(0, state.recommendationCount);
$("#sacrificeList").innerHTML = weakest.map(({ piece, score, reasons }) => ` $("#sacrificeList").innerHTML = weakest.map(({ piece, score, reasons }) => `
<li><strong>${escapeHtml(piece.name || piece.title)}</strong> <li><strong>${escapeHtml(piece.name || piece.title)}</strong>
<small>Score ${fmt(score)}. ${reasons.length ? reasons.join("; ") : "Lowest relative contribution among entered pieces."}</small> <small>Score ${fmt(score)}. ${reasons.length ? reasons.join("; ") : "Lowest relative contribution among entered pieces."}</small>